Open
Conversation
This removes the need to instantiate a JqueryDatepicker that we only use to scrape attributes before rendering a generic TextField Now we can instantate the JqueryDatePicker and it renders the text field as it should, and provides an accessor to get at all the DatePicker specific attributes
Author
|
I had forgotten to drop ruby 1.9.2 from the travis build. I replaced it with the latest-and-greatest 2.1.4 and now things look happy. |
|
is there any change this will be merged into master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with @hale's fix, upgraded rails to 4.1.6, and made a handful of changes to get all the tests passing again. The switch from InstanceTag to Tags::TextField implies this will only work for Rails 4.1 and later.
I also re-factored it a bit (separate commit) to avoid needing to copy parts of the options hash between a JqueryDatePicker::InstanceTag and a TextField. Now you can directly render the JqueryDatePicker::InstanceTag. All tests should still be passing.